search

eclipsesource / jsonforms-vuetify-renderers

https://jsonforms-vuetify-renderers.netlify.app/
Other
25 stars 26 forks source link

Fix vue3 #112

Open kchobantonov opened 1 month ago

kchobantonov commented 1 month ago
  1. Fixing all discovered vue3/vuetify3 issues
  2. Integrate with Vite
  3. Update example project
    • having more settings to control locale
    • selectable icon set (material icons vs font awesome ),
    • configurable blueprints (Material Design 1, 2, 3)
    • configurable variants (regular, solo, filled, etc.)
    • jsonform & vuetify icons are now colored based on the theme
  4. Integrate the date/time/datetime controls with mask - respecting the selected locale for language and formatting
netlify[bot] commented 1 month ago

Deploy Preview for jsonforms-vuetify-renderers failed.

Name Link
Latest commit 4e75cd9a9c71c366005a56995b6e5485d62b5e38
Latest deploy log https://app.netlify.com/sites/jsonforms-vuetify-renderers/deploys/6656e675fd27f40008922ad3
kchobantonov commented 1 month ago

@sdirix please review - at the moment we have conflicts since my work is based on the repository from 2 days ago and I have very large change as you can see - probably it will be good if we override that or something. You can review and build https://github.com/kchobantonov/jsonforms-vuetify-renderers/tree/fix-vue3 - let me know how you want this handled - didn't expect some changes and I have a lot of those at the moment.

sdirix commented 1 month ago

Hi @kchobantonov,

wow, thank you for the massive contribution :heart:

While we did touch a lot of files, I think the conflicts should be rather easy to solve as conceptually it was just a small amount of changes.

However I would prefer to not fully polish this PR but going in a different direction:

In the JSON Forms team we decided that we want to archive this repository and move the vue-vuetify renderer set into the core repository to ease the maintenance in the future. This means that any @jsonforms/core and @jsonforms/vue adaption is immediately integrated in @jsonforms/vue-vueitfy too while @jsonforms/vue-vuetify will then automatically be part of the normal release process.

Would you like to contribute this move to the core repository? If yes, feel free to open a PR against the main repository with the current state of the Vue3 vuetify renderers, including your additional improvements on top. If not, then we will do the move at some point in June ourselves and you can then open a PR against the core repository with the changes contained in here.

kchobantonov commented 1 month ago

@sdirix should will create a new PR against the main repo.