search

eclipsesource / jsonforms-vuetify-renderers

https://jsonforms-vuetify-renderers.netlify.app/
Other
27 stars 26 forks source link

Add tests #56

Closed kchobantonov closed 2 years ago

kchobantonov commented 2 years ago

Add unit tests and apply various fixes

netlify[bot] commented 2 years ago

Deploy Preview for jsonforms-vuetify-renderers ready!

Name Link
Latest commit 1a660b4cc48f1cd1a77a9024ff500543032fb366
Latest deploy log https://app.netlify.com/sites/jsonforms-vuetify-renderers/deploys/62babbcfb330560008e4ce9b
Deploy Preview https://deploy-preview-56--jsonforms-vuetify-renderers.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kchobantonov commented 2 years ago

@sdirix please review. one thing to note is that currently unit test involve snapshot testing as well and there might be issues with generating stable snapshots (e.g. where the ids and etc. does not change from time to time) I have make sure that at least the ids that are generated from jsonforms are reset every time when we run a test but I have seen cases where vuetify generates also attributes with generated values that are not always the same. So it is up to you to decided if the tests should be included in the automated build (which I prefer) but I haven't done that just because of the above issue.