search

eclipsesource / jsonforms-vuetify-renderers

https://jsonforms-vuetify-renderers.netlify.app/
Other
26 stars 26 forks source link

Horizontal layout cols not working #67

Closed davidpede closed 2 years ago

davidpede commented 2 years ago

Upgraded to latest beta and horizontal cols have stopped working. Column widths set like this: https://github.com/eclipsesource/jsonforms-vuetify-renderers/blob/a3b1927813ef8e0cefc424e3025850ecda3cdd67/example/src/examples/horizontal-layout/uischema.json#L23 have no effect.

Docs site demos the issue: https://jsonforms-vuetify-renderers.netlify.app/#/example/horizontal-layout

Was working in beta-1

kchobantonov-runbuggy commented 2 years ago

@sdirix this is not working since there is a cols binding at the moment that take precedence.

sdirix commented 2 years ago

Hmm I see.

This collides with the collapse feature. We should probably also check the cols of the vuetifyProps and use them except for when the breakpoint collapse takes precedence. Do you agree?

kchobantonov commented 2 years ago

yes we do need to do some sort of a merge since to make the jsonform responsive automatically most likely won't work out of the box or at least not the way how the end user might expect it. I was also thinking on how to make that automatically responsive but with all variants and even hiding/showing UI elements bases on the screen size it will be better I guess to leave that as options in the UI elements (json UI schema)

sdirix commented 2 years ago

I pushed a fix to #68

sdirix commented 2 years ago

Fixed with https://github.com/eclipsesource/jsonforms-vuetify-renderers/pull/68