search

eclipsesource / jsonforms-vuetify-renderers

https://jsonforms-vuetify-renderers.netlify.app/
Other
25 stars 26 forks source link

fixes #75 #76

Closed kchobantonov closed 1 year ago

kchobantonov commented 1 year ago

Fixes #75

netlify[bot] commented 1 year ago

Deploy Preview for jsonforms-vuetify-renderers ready!

Name Link
Latest commit f39525a0c17c97a58f8a48319d66de82dd381328
Latest deploy log https://app.netlify.com/sites/jsonforms-vuetify-renderers/deploys/6357e758a996eb00098e65c3
Deploy Preview https://deploy-preview-76--jsonforms-vuetify-renderers.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kchobantonov commented 1 year ago

@sdirix please review

kchobantonov commented 1 year ago

@sdirix I also added the ability to translate the dropdown labels

sdirix commented 1 year ago

Thanks for the PR :heart: , I'll take a look

kchobantonov commented 1 year ago

I added some minor comments. Something seems to be broken with the enums. See the enum example: https://deploy-preview-76--jsonforms-vuetify-renderers.netlify.app/#/example/enum If you open the console you can also see errors. It doesn't seem to find the translation function to translate the item labels:

vue.runtime.esm.js:3020 TypeError: e.t is not a function
    at item-text (app.c5b53e55.js:1:118544)

thanks for catching this. I will fix in the next commit

kchobantonov commented 1 year ago

@lucas-koehler please review again - https://deploy-preview-76--jsonforms-vuetify-renderers.netlify.app/#/example/enum