eclipsesource / jsonforms-vuetify-renderers

https://jsonforms-vuetify-renderers.netlify.app/
Other
26 stars 26 forks source link

Fixes layouts #93

Closed kchobantonov closed 1 year ago

kchobantonov commented 1 year ago

Fixing layouts, translations, minor fixes

netlify[bot] commented 1 year ago

Deploy Preview for jsonforms-vuetify-renderers ready!

Name Link
Latest commit 63cbd3d2547d996f89bd5a8e08387cada07929b5
Latest deploy log https://app.netlify.com/sites/jsonforms-vuetify-renderers/deploys/647d877950b35e0007c76387
Deploy Preview https://deploy-preview-93--jsonforms-vuetify-renderers.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kchobantonov commented 1 year ago

@sdirix @lucas-koehler please review

kchobantonov commented 1 year ago

@sdirix will you have some time next week to review this and if good to have a release ? Also did you decide if we want to include the FileRenderer and perhaps close the PR for the TemplateRenderer if indeed you do not want that added to this project like the webcomponent.

lucas-koehler commented 1 year ago

Hello @kchobantonov , sorry for the late reply and thanks again for the contributions. We are going to review this PR and create a release in the next two weeks. We decided to not introduce the template renderer. I'll close that PR.

kchobantonov commented 1 year ago

@sdirix I have updated this branch to use jsonforms 3.1.0-alpha.3 and I added the suggested changes for the translations except for the tooltips for

array.btn.moveUp.tooltip array.btn.moveDown.tooltip

I couldn't find any any translation properties for the up/down tooltip - only for the aria label

kchobantonov commented 1 year ago

@lucas-koehler @sdirix can you please review - I have included the changes from https://github.com/eclipsesource/jsonforms-vuetify-renderers/pull/92 as well as the suggestions for the translation except for few of those that I couldn't find. Also any plans for a release for this project where this PR is included ?

Thanks

sdirix commented 1 year ago

Released as part of 3.1.0-alpha.3