Open Altair-Bueno opened 1 year ago
Hi @Altair-Bueno,
That's a good point. I don't see a downside to also set the name
properties, so I would be fine to add this to the Vanilla renderer set. Do you want to contribute this feature?
Hey @sdirix
Sure, I can give it a try. However, i'm not familiar with the codebase. Could you give me some guidance on what needs to be changed? My guess is the vanilla-renderers package, particularly each input cell. Is that so?
Yes exactly, that is the correct place!
Thanks for the followup @sdirix. Unfortunately I had some issues with the Dev container (see https://github.com/eclipsesource/jsonforms/issues/2149). Hopefully is something with an easy fix.
In the meantime, I've reading the codebase a bit. I'm concerned that the cells do not receive their paths as props (something like ["foo",0,"bar"]
). Ideally, we would want each input to have a meaningful name derived from said path, so it could be easily decoded from the backend. I suggest something like jQuery's param encoding, which is supported pretty much everywhere these days.
Is your feature request related to a problem? Please describe.
The
name
attribute is essential for server first websites that leverage traditional form submission workflows. Consider the following React component and scheme:This renders successfully but
name
attributes are nowhere to be seenWithout
name
attributes, submitting the form sends nothing.Describe the solution you'd like
Include
name
attributes on each input field.Describe alternatives you've considered
Framework
Core
RendererSet
Vanilla
Additional context
No response