eclipsesource / jsonforms

Customizable JSON Schema-based forms with React, Angular and Vue support out of the box.
http://jsonforms.io
Other
2.22k stars 373 forks source link

fix(translations): memoize array translation #2358

Closed LukasBoll closed 2 months ago

LukasBoll commented 4 months ago

This commit addresses an issue where array translations were created as new objects within the core module for each render cycle, causing unnecessary rerenders. By memoizing the translation object in the material renderer set, this commit optimizes performance and prevents redundant rerenders.

netlify[bot] commented 4 months ago

Deploy Preview for jsonforms-examples ready!

Name Link
Latest commit 0e697e75f59da1dc2a6e1e169e3e7ecd8f795698
Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/66be575ee1c5a000082d87f5
Deploy Preview https://deploy-preview-2358--jsonforms-examples.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sdirix commented 3 months ago

@LukasBoll Can you fix the build or do you need support?

coveralls commented 3 months ago

Coverage Status

coverage: 81.733% (-1.6%) from 83.285% when pulling c64196b17c42ccee60a0a97bf958dc5377337060 on LukasBoll:resolve_translation_rerender into 52b843a9743967136221f210a413139fee54b21d on eclipsesource:master.

netlify[bot] commented 3 months ago

Deploy Preview for jsonforms-examples ready!

Name Link
Latest commit c64196b17c42ccee60a0a97bf958dc5377337060
Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/66e4636c30eae20008c99350
Deploy Preview https://deploy-preview-2358--jsonforms-examples.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

LukasBoll commented 3 months ago

Hi @sdirix, I just fixed the build issues :)

sdirix commented 3 months ago

@LukasBoll Can you resolve the conflicts?

lucas-koehler commented 2 months ago

Merge commit only fixes a tiny merge conflict.