search

eclipsesource / jsonforms

Customizable JSON Schema-based forms with React, Angular and Vue support out of the box.
http://jsonforms.io
Other
2.22k stars 373 forks source link

vue-vanilla - postfix of id of select element should be '-input' not '-select' #2363

Closed changjung-kim closed 3 months ago

changjung-kim commented 4 months ago

Describe the bug

postfix of id of label id for enum type is set to '-select' though the label's for is expecting the postfix '-input' due to the code https://github.com/eclipsesource/jsonforms/blob/d3ee13a059ff9e0bc6dc9282b8f0ca65b799f5e6/packages/vue-vanilla/src/controls/EnumControlRenderer.vue#L9 .

Expected behavior

postfix of id of select element should be '-input'.

Steps to reproduce the issue

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots

No response

Which Version of JSON Forms are you using?

v3.3.0

Framework

Vue

RendererSet

Vanilla

Additional context

No response

sdirix commented 3 months ago

@changjung-kim Thanks for the report! Would you like to contribute the fix?

changjung-kim commented 3 months ago

Okay. Sure.

sdirix commented 3 months ago

Hi @changjung-kim I see you developed a fix. Would you like to open a PR?

changjung-kim commented 3 months ago

Hi @sdirix Yes. I did. Please review and merge the PR. :smiley:

sdirix commented 3 months ago

Fixed with https://github.com/eclipsesource/jsonforms/pull/2368