Implement palette and modeling assistants for UML Light sequence diagram. The latter requires additionally installing the popup-bar edit-policy on the interaction compartment for the Lifeline assistant.
Incidentally fix up the “Comment Link” icon in the palette of all UML Light diagrams to match the class diagram (instead of showing a comment node, which is misleading).
This pull request does not address the New Child menu in the Model Explorer.
Caveats
There are several problems in the Papyrus implementation of the sequence diagram that affect the modeling assistants, such that I'm not sure that we should defined these assistants until bugs in the diagram can fixed, or perhaps even at all.
connection handles cannot create the target/source element of the connection using the "To/From New Xyz" action. Some weak-reference edit-policy in the diagram throws an NPE on a null Point after the target/source element is created and visualized in the diagram, so that
the connection element (e.g., message or comment attachment) is not created
the undo history is corrupted and the editor may not even be dirty if this was the first edit
the connection handles don't actually show up on message edit-parts even when the edit-policy is installed and tries to create them (would be nice for creating comment attachments)
the connection handles on comment shapes don't work at all in this diagram; comment attachments can only be created via the assistants from the annotated-element end
Note that none of these problems is worse than several other bugs in the sequence diagram that don't relate to assistants at all and have similarly dire consequences. but, even so, we may want to defer the assistants altogether, at least for now. Or perhaps only the connection assistants, as the pop-up assistants seem to work.
Implement palette and modeling assistants for UML Light sequence diagram. The latter requires additionally installing the popup-bar edit-policy on the interaction compartment for the
Lifelineassistant.Incidentally fix up the “Comment Link” icon in the palette of all UML Light diagrams to match the class diagram (instead of showing a comment node, which is misleading).
This pull request does not address the New Child menu in the Model Explorer.
Caveats
There are several problems in the Papyrus implementation of the sequence diagram that affect the modeling assistants, such that I'm not sure that we should defined these assistants until bugs in the diagram can fixed, or perhaps even at all.
Pointafter the target/source element is created and visualized in the diagram, so thatNote that none of these problems is worse than several other bugs in the sequence diagram that don't relate to assistants at all and have similarly dire consequences. but, even so, we may want to defer the assistants altogether, at least for now. Or perhaps only the connection assistants, as the pop-up assistants seem to work.