search

eclipsesource / papyrus-umllight

Eclipse Public License 2.0
4 stars 2 forks source link

Fix RCP feature name, inlcude Papyrus Compare and add Compare pre-configuration #87

Closed planger closed 5 years ago

planger commented 5 years ago

As this is probably one of the last changes, we merge before "releasing" UMLLight, please test this change also quite in detail (also with the built product). Thanks!

planger commented 5 years ago

Strange, the CI didn't correctly report the build result: https://travis-ci.org/eclipsesource/papyrus-umllight/builds/485416013

tortmayr commented 5 years ago

Strange, the CI didn't correctly report the build result: https://travis-ci.org/eclipsesource/papyrus-umllight/builds/485416013

I did close and reopen the PR to retrigger the build. Maybe it works now

planger commented 5 years ago

Good idea, this seem to have worked! Or it was my restart of the build, who knows :) Anyway, now this is ready for review. Thanks!

tortmayr commented 5 years ago

I did try a manual restart of the build before as well but it had no affect. At least now we now that reopening the pull request works if we run into that issue again in the future :wink:

tortmayr commented 5 years ago

Apparently my local maven environment was corrupted and the build product didn't have the latest changes. After cleaning my .m2 folder the built product now works as expected.

planger commented 5 years ago

Thanks a lot!