eclipsesource / tabris-js

Create native mobile apps in JavaScript or TypeScript.
https://tabrisjs.com
BSD 3-Clause "New" or "Revised" License
1.4k stars 170 forks source link

Improve appearance of tabBarLocation "bottom" on Android #1130

Closed mpost closed 7 years ago

mpost commented 7 years ago

Positioning the tab bar the bottom works as expected, the tabs move to the bottom but the visual appearance is not very pleasing. We should consider using the recently introduced BottomNavigationView introduced in the android design library for a more native looking bottom tab bar.

mpost commented 7 years ago

The Android client will now make use of the BottomNavigationView as described above. Note that due the natural limitation of the BottomNavigationView, a TabFolder with the tabBarPosition property set to bottom is currently limited to a maximum of 5 tabs. An error will be logged when additional tabs are added.

The following screenshots show the TabFolder in its default appearance and with textColor and background set:

tabfolder-bottom

screenshot_1486986914 screenshot_1486986870

mpost commented 7 years ago

As discussed above we have now update the Tabris.js Android client to use the BottomNavigationView to show tabs at the bottom.