Dialog for requesting notification permissions is shown prematurely

eclipsesource / tabris-plugin-firebase

A firebase plugin for Tabris.js

https://tabrisjs.com

BSD 3-Clause "New" or "Revised" License

6 stars 5 forks source link

Dialog for requesting notification permissions is shown prematurely #27

Closed cpetrov closed 6 years ago

cpetrov commented 6 years ago

Problem description

The notification permission dialog opens as soon as the app is launched. It is common to only show a dialog requesting permissions after informing the user about the usage of those permissions.

Expected behavior

The developer should be able to request the notification permission on demand.

Environment

Tabris.js version: 2.2.0
Device: iPad Air
OS: iOS 10

Code snippet

Build an app with the Firebase plugin and load an empty source file.

cpetrov commented 6 years ago

Fixed in 0835ea4f7202a12cdf1a36fe10d06d5f7516da6a and 8e1b9bd0a21639925695c8562c6523abaaa2ae9b.