Open gaspardthrl opened 1 year ago
modified weth addresses
The test is not working for the main branch. I'm working on it this evening
The problem comes from the fact that we use FeedRegistry contract (chainlink), which is only available on ETH mainnet (and not on polygon, if I understand correctly from what I saw on Chainlink's docs).
@GustaveCharles Any idea on how to make a pricefeed contract relying on chainlink without FeedRegistry?
https://www.youtube.com/watch?v=uGtU2xUkc70 @devsquaaa @GustaveCharles
Yes I can change that, if we want to test on Polygon I can change the PriceFeed so that we use the PriceFeed contracts which are on Polygon. The only drawback is that we will need beforehand a list of the tokens we want to fetch the prices from as the PriceFeed contracts only allow a known set of tokens to fetch the prices from. So I suggest that we start with one or two pools on Polygon, the USC/WETH pool and/or the MATIC/WETH pool, which have the most liquidity.
On Thu, 6 Apr 2023 at 09:10, squaaa @.***> wrote:
The problem comes from the fact that we use FeedRegistry https://docs.chain.link/data-feeds/feed-registry contract (chainlink), which is only available on ETH mainnet (and not on polygon, if I understand correctly from what I saw on Chainlink's docs).
@GustaveCharles https://github.com/GustaveCharles Any idea on how to make a pricefeed contract relying on chainlink without FeedRegistry?
— Reply to this email directly, view it on GitHub https://github.com/eclypse-labs/eclypse-core/issues/13#issuecomment-1498596623, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVXVZIJ4ZHZGXDMGGIDXJSDW7ZUABANCNFSM6AAAAAAWQ5YEBA . You are receiving this because you were mentioned.Message ID: @.***>
**I can change the FeedRegister so that we use the PriceFeed contracts
On Thu, 6 Apr 2023 at 11:09, Gus BCN @.***> wrote:
Yes I can change that, if we want to test on Polygon I can change the PriceFeed so that we use the PriceFeed contracts which are on Polygon. The only drawback is that we will need beforehand a list of the tokens we want to fetch the prices from as the PriceFeed contracts only allow a known set of tokens to fetch the prices from. So I suggest that we start with one or two pools on Polygon, the USC/WETH pool and/or the MATIC/WETH pool, which have the most liquidity.
On Thu, 6 Apr 2023 at 09:10, squaaa @.***> wrote:
The problem comes from the fact that we use FeedRegistry https://docs.chain.link/data-feeds/feed-registry contract (chainlink), which is only available on ETH mainnet (and not on polygon, if I understand correctly from what I saw on Chainlink's docs).
@GustaveCharles https://github.com/GustaveCharles Any idea on how to make a pricefeed contract relying on chainlink without FeedRegistry?
— Reply to this email directly, view it on GitHub https://github.com/eclypse-labs/eclypse-core/issues/13#issuecomment-1498596623, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVXVZIJ4ZHZGXDMGGIDXJSDW7ZUABANCNFSM6AAAAAAWQ5YEBA . You are receiving this because you were mentioned.Message ID: @.***>
You can implement the fix and I'll add the required token pair addresses to the feed
@GustaveCharles
We need to check that all the addresses are the one for polygon.