eclypse-labs / eclypse-core

The core contracts of the eclypse protocol
1 stars 0 forks source link

Swap Liquidation Test Implementation is not relevant #15

Closed gaspardthrl closed 1 year ago

gaspardthrl commented 1 year ago

When we test if a position is liquidable after a swap, it seems to me that it will never be since the values of tokens don't change, only their amounts.

It worked before, even though we were only affecting uniswap pools, because we used the uniswap twap to also fetch the prices. Now with chainlink to simulate a price change we would need to affect every source of the chainlink oracle.