eclypse-labs / eclypse-core

The core contracts of the eclypse protocol
1 stars 0 forks source link

[internal to code design, no change to the interface] PoolPricingInfo is now obsolete, should be removed. #19

Closed devsquaaa closed 1 year ago

devsquaaa commented 1 year ago

Title says it all. Since we now use the price feed, these lines should be removed :

struct PoolPricingInfo {
    address poolAddress;
    bool inv; // True iff WETH is token0 of the pool.
}
if (_token0 != WETHAddress) {
        tokenToWETHPoolInfo[_token0] = PoolPricingInfo(_ETHpoolToken0, _inv0);
}
if (_token1 != WETHAddress) {
    tokenToWETHPoolInfo[_token1] = PoolPricingInfo(_ETHpoolToken1, _inv1);
}
mapping(address => PoolPricingInfo) private tokenToWETHPoolInfo;

Can you confirm @Lolshh ?

gaspardthrl commented 1 year ago

yes I do confirm.