ecmnet / MAVGCL

In-Flight Analysis for PX4
176 stars 68 forks source link

Release build does not contain dependencies #59

Closed ecmnet closed 7 years ago

ecmnet commented 8 years ago

@dagar Currently the release build does not contain the dependent libraries. Could you fix this by building a zip file containing all necessary files?

dagar commented 8 years ago

We could make that a generic deploy in the ant script, then point travis at the resulting zip.

Or could we put all dependencies in a single jar? I'm not sure what best practices are for java packaging.

ecmnet commented 8 years ago

The ant-script already contains a packaging for OSX. Could we publish that instead? I could add targets for Linux and perhaps Windows as well then.

dagar commented 8 years ago

We should probably do all of the above. Some people will want packages, some people won't.

The OSX packaging is already on travis-ci, I just haven't uploaded it yet because the file is named MAVGAnalysis-1.0.dmg. We can either try to be clever and auto name from the git tag, or rename it generically. https://travis-ci.org/ecmnet/MAVGCL/jobs/140031032#L575

Can you only create packages for the same system as the build host? Can we use a travis-ci linux builder to create them all?

ecmnet commented 8 years ago

I don't think its called MAVGAnalysis-1.0.dmg, but MAVGAnalysis.dmg. So I don't understand exactly what you mean. I added the javafx build targets for Linux and Windows, but I cannot test those, as the build runs only on the os of my host (OS X).

dagar commented 8 years ago

https://travis-ci.org/ecmnet/MAVGCL/jobs/140031032#L575

Result DMG installer for MAVGAnalysis: 
/Users/travis/build/ecmnet/MAVGCL/MAVGCL/dist/deploy/bundles/MAVGAnalysis-1.0.dmg
ecmnet commented 8 years ago

Ok. I added the version attribute to the script. Output should be MAVGAnalysis-0.3.dmg

ecmnet commented 8 years ago

Could you try a Linux/Windows build?

dagar commented 8 years ago

I've added Linux to travis-ci - #60 We'll need to add configure appveyor for Windows builds.

On Fri, Jun 24, 2016 at 10:41 AM, Eike notifications@github.com wrote:

Could you try a Linux/Windows build?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ecmnet/MAVGCL/issues/59#issuecomment-228364559, or mute the thread https://github.com/notifications/unsubscribe/AAFK6NatfCRxIwGleUEbdC4y9f9wUtlNks5qO-ymgaJpZM4I9wJd .

ecmnet commented 8 years ago

Thanks a lot. Maybe we could skip the windows build for now, as the tool is targeted to dev mainly, which use Linux/OSX most. UPDATE: Oh just saw, you already started with appveyor..

dagar commented 8 years ago

Should we also do a "fat" jar with all the dependencies?

ecmnet commented 8 years ago

@dagar I don't see the need of a fat jar, if we make platform specific builds. I added the repo to an appveyor account, btw, but build fails currently.