search

ecmwf-ifs / ectrans

Global spherical harmonics transforms library underpinning the IFS
Apache License 2.0
15 stars 30 forks source link

Remove NCOMBFLEN parameter #114

Closed samhatfield closed 5 days ago

samhatfield commented 1 week ago

This wasn't used anywhere.

wdeconinck commented 1 week ago

Interesting find. I wonder when it was removed...

Similar to a previous cleanup, I would ask to keep the API stable but deprecate the use of kcombflen in setup_trans0 because this parameter is still used in e.g. ifs-source/arpifs/setup/sutrans0.F90

Definitely however we should have another ifs-source commit to fix the use of these deprecated parameters.

samhatfield commented 5 days ago

It was removed 16 years ago :p

But yes I will keep the argument but issue a warning. Just a second.

samhatfield commented 5 days ago

PR updated.

wdeconinck commented 5 days ago

16!!! years? Good riddance.