search

ecmwf-ifs / ectrans

Global spherical harmonics transforms library underpinning the IFS
Apache License 2.0
15 stars 30 forks source link

Some changes related to CONTIGUOUS #94

Closed DJDavies2 closed 2 months ago

DJDavies2 commented 2 months ago

This is for #93, it seems to fix the Intel issue.

I don't know if this is acceptable as it removes the CONTIGUOUS from a dummy argument. I think this is a problem with the compiler.

samhatfield commented 2 months ago

Could you send this PR to ecmwf-ifs:develop instead of ecmwf-ifs:main?

DJDavies2 commented 2 months ago

Could you send this PR to ecmwf-ifs:develop instead of ecmwf-ifs:main?

I see this has been done?

DJDavies2 commented 2 months ago

Will it be possible to get this change merged?

samhatfield commented 2 months ago

I have no problem with it personally, but we need to check this is okay with our Météo-France colleagues as they introduced the CONTIGUOUS statements. I'll try to get an answer from them.

DJDavies2 commented 2 months ago

Closing as #93 is closed.