search

ecmwf-ifs / fiat

The Fortran IFS and Arpege Toolkit
Apache License 2.0
9 stars 24 forks source link

Remove empty subroutine definition #10

Closed raguridan closed 1 year ago

raguridan commented 1 year ago

The subroutine cause the ifort compiler to generate compilation errors when compiling ifs-source/arpifs/oops/error_covariance_3d_mod.F90.

Before merging this PR, ifs-source needs to be updated to remove the references to the removed subroutine. The following files need to be changed:

The references to the removed function need to be replaced by a call to SET_ABOR1_EXCEPTION_HANDLER, which does the same things as the currently existing code.

Additionally, the corresponding file in the ifs-source/contrib/fiat directory needs to be updated.

An ifs-source changeset containing the above mentioned changes can be back ported from the climate DT.

FussyDuck commented 1 year ago

CLA assistant check
All committers have signed the CLA.

raguridan commented 1 year ago

Rejected due to alternative PR from Willem.