ecmwf-ifs / field_api

Apache License 2.0
3 stars 8 forks source link

add continous integration with the last intel compilers #17

Closed dareg closed 8 months ago

dareg commented 9 months ago

Downloads and install the last intel compilers from their official repository and run the field_api tests.

Note that it uses the new icx and ifx compilers instead of the old icc and ifort compilers.

awnawab commented 9 months ago

Happy new year @dareg and thanks for this much needed addition to the CI. We don't currently use ifx for ifs builds. Have you started using it? If you don't use it either, then perhaps it might be more useful to use ifort for the CI too. You can see an example here of how ifort rather than ifx can be installed: https://github.com/ecmwf-ifs/ecwam/blob/main/.github/tools/install-intel-oneapi.sh

dareg commented 9 months ago

Hello,and happy new year too.

For the moment we don't use ifx either, we are still using ifort too. But since November 2023 ifort is officially deprecated [1] and will be discontinued at the end of 2024, so I think it would good to check that our tests pass with ifx since I guess it would be the compiler installed on any new x86-64 supercomputer. That being said it's true that we should still test with ifort since this the one we use today. I think both ifort and ifx are installed in the package intel-hpckit for now, so I propose that we run the tests with both.

[1] https://community.intel.com/t5/Blogs/Tech-Innovation/Tools/Deprecation-of-The-Intel-Fortran-Compiler-Classic-ifort/post/1541699

awnawab commented 9 months ago

Testing with both ifort and ifx makes a lot of sense to me too, I'd be happy with that!

awnawab commented 8 months ago

Hi @dareg. I have to file a fix for the FIELD_API build and CI setup. Do you think we could wrap up this PR soon, and then I'll rebase my changes on top of yours?

FussyDuck commented 8 months ago

CLA assistant check
All committers have signed the CLA.

dareg commented 8 months ago

Done, @awnawab . I've added the tests with the classic intel compilers into their own file. Will be easy to remove them when we won't need them any more.