ecmwf-ifs / loki

Freely programmable source-to-source translation for Fortran
https://sites.ecmwf.int/docs/loki/
Apache License 2.0
22 stars 11 forks source link

Block-index injection transformations #303

Closed awnawab closed 1 month ago

awnawab commented 2 months ago

In order to mitigate the cost of creating thread-local copies of data structures, per-block views of fields can be replaced with full field views and the block-index can be inserted into the field pointer.

This is achieved via two transformations:

github-actions[bot] commented 2 months ago

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/303/index.html

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 99.03537% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 95.14%. Comparing base (f3e7d90) to head (6707094).

Files Patch % Lines
...oki/transformations/block_index_transformations.py 98.70% 2 Missing :warning:
...i/transformations/tests/test_block_index_inject.py 98.97% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #303 +/- ## ========================================== + Coverage 95.12% 95.14% +0.02% ========================================== Files 165 167 +2 Lines 35143 35374 +231 ========================================== + Hits 33429 33656 +227 - Misses 1714 1718 +4 ``` | [Flag](https://app.codecov.io/gh/ecmwf-ifs/loki/pull/303/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs) | Coverage Δ | | |---|---|---| | [lint_rules](https://app.codecov.io/gh/ecmwf-ifs/loki/pull/303/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs) | `96.38% <ø> (-0.02%)` | :arrow_down: | | [loki](https://app.codecov.io/gh/ecmwf-ifs/loki/pull/303/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs) | `95.12% <99.03%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

awnawab commented 2 months ago

Thanks again @reuterbal for the derived-type enrichment fix 🙏