search

ecmwf-ifs / loki

Freely programmable source-to-source translation for Fortran
https://sites.ecmwf.int/docs/loki/
Apache License 2.0
22 stars 11 forks source link

IR: Fix `get_pragma_params` for multiline pragmas #313

Closed mlange05 closed 2 months ago

mlange05 commented 2 months ago

The recent addition of parse_expr for reading pragma parameters does not account for multi-line pragmas with & linebreaks. This PR fixes this and adds a small test for this.

I've also piggy-backed a small fix to loki-transform.py, where the recent introduction of RemoveCodeTransformation was not told to keep DR_HOOK calls in the drivers via the kernel_only option. With these two changes, EC-physics regression should be fine again.

github-actions[bot] commented 2 months ago

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/313/index.html

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.11%. Comparing base (5300280) to head (ddb3e0d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #313 +/- ## ======================================= Coverage 95.11% 95.11% ======================================= Files 165 165 Lines 35065 35079 +14 ======================================= + Hits 33351 33365 +14 Misses 1714 1714 ``` | [Flag](https://app.codecov.io/gh/ecmwf-ifs/loki/pull/313/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs) | Coverage Δ | | |---|---|---| | [lint_rules](https://app.codecov.io/gh/ecmwf-ifs/loki/pull/313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs) | `96.39% <ø> (ø)` | | | [loki](https://app.codecov.io/gh/ecmwf-ifs/loki/pull/313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs) | `95.09% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.