search

ecmwf-ifs / loki

Freely programmable source-to-source translation for Fortran
https://sites.ecmwf.int/docs/loki/
Apache License 2.0
22 stars 11 forks source link

`DataFlowAnalysis` bug fixes #320

Closed awnawab closed 1 month ago

awnawab commented 1 month ago

This PR fixes the following bugs in the DataFlowAnalysis:

  1. Module imports are now only marked as defined if they are ProcedureSymbols
  2. CallStatement argument arrays indexed indirectly now no longer add the array representing the indirection to the defined set
  3. VariableDeclaration nodes now add symbols used to define array sizes to the uses set

The GlobalVariableAnalysis now also adds symbols used in subroutine.spec to the uses_symbols set.

github-actions[bot] commented 1 month ago

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/320/index.html

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.14%. Comparing base (77114a9) to head (cf8c8e5). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #320 +/- ## ======================================= Coverage 95.14% 95.14% ======================================= Files 167 167 Lines 35374 35387 +13 ======================================= + Hits 33657 33670 +13 Misses 1717 1717 ``` | [Flag](https://app.codecov.io/gh/ecmwf-ifs/loki/pull/320/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs) | Coverage Δ | | |---|---|---| | [lint_rules](https://app.codecov.io/gh/ecmwf-ifs/loki/pull/320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs) | `96.38% <ø> (ø)` | | | [loki](https://app.codecov.io/gh/ecmwf-ifs/loki/pull/320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs) | `95.12% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.