search

ecmwf-ifs / loki

Freely programmable source-to-source translation for Fortran
https://sites.ecmwf.int/docs/loki/
Apache License 2.0
29 stars 12 forks source link

Add transformation generated imports to driver or after inlining #321

Closed awnawab closed 3 months ago

awnawab commented 3 months ago

This PR provides the following fixes:

  1. TemporariesPoolAllocator transformation now adds global variable imports to the driver for variables used to define array sizes.
  2. HoistArraysTransformation adds imports used to define the sizes of hoisted variables.
  3. The addition of module imports from inlined children in the InlineTransformation is fixed.
  4. InlineTransformation now also adds any explicit interfaces from inlined children.
github-actions[bot] commented 3 months ago

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/321/index.html

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.16%. Comparing base (eb793e2) to head (78d9f45).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #321 +/- ## ======================================= Coverage 95.15% 95.16% ======================================= Files 168 168 Lines 35454 35503 +49 ======================================= + Hits 33737 33786 +49 Misses 1717 1717 ``` | [Flag](https://app.codecov.io/gh/ecmwf-ifs/loki/pull/321/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs) | Coverage Δ | | |---|---|---| | [lint_rules](https://app.codecov.io/gh/ecmwf-ifs/loki/pull/321/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs) | `96.38% <ø> (ø)` | | | [loki](https://app.codecov.io/gh/ecmwf-ifs/loki/pull/321/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs) | `95.14% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

awnawab commented 3 months ago

Many thanks @reuterbal for the super prompt review and feedback 🙏 I've addressed all your comments, please have another look whenever you can!

reuterbal commented 3 months ago

Apologies, this has accrued conflicts now - @awnawab, would you mind rebasing this over main?