search

ecmwf-ifs / loki

Freely programmable source-to-source translation for Fortran
https://sites.ecmwf.int/docs/loki/
Apache License 2.0
29 stars 12 forks source link

Fix wrong classification as StatementFunction in translation to Loki IR #327

Closed reuterbal closed 3 months ago

reuterbal commented 3 months ago

Sigh....

Found with scan2m.F90, correctly removing all misclassifications now.

github-actions[bot] commented 3 months ago

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/327/index.html

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.18%. Comparing base (eb793e2) to head (3526b9f). Report is 14 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #327 +/- ## ========================================== + Coverage 95.15% 95.18% +0.02% ========================================== Files 168 168 Lines 35454 35645 +191 ========================================== + Hits 33737 33929 +192 + Misses 1717 1716 -1 ``` | [Flag](https://app.codecov.io/gh/ecmwf-ifs/loki/pull/327/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs) | Coverage Δ | | |---|---|---| | [lint_rules](https://app.codecov.io/gh/ecmwf-ifs/loki/pull/327/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs) | `96.39% <ø> (+0.01%)` | :arrow_up: | | [loki](https://app.codecov.io/gh/ecmwf-ifs/loki/pull/327/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs) | `95.16% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf-ifs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

reuterbal commented 3 months ago

I think this is ready for another look @mlange05 As discussed offline, the type attribute is gone and the heuristic is handled differently - in the process I fixed some OFP issues.