search

ecmwf-lab / ecml-tools

Apache License 2.0
6 stars 1 forks source link

Set up pre-commit to handle linting (also in cicd) #2

Open leifdenby opened 7 months ago

leifdenby commented 7 months ago

I have a quick suggestion I would like to make which would be set up pre-commit to handle the linting. pre-commit is easy to run locally (it can be installed with a git hook to run on every commit), ties in easily with github actions and with the same configuration locally and on cicd it easier to ensure that code stays clean.

If this sounds good I am happy to add the configuration and set up the cicd part too :smile: I am primarily asking @b8raoult because I just noticed you did a commit for handling some linting fixes for black.

JesperDramsch commented 7 months ago

Hi @leifdenby, thanks for the suggestion.

we had a pretty hefty pre-commit flying around that I worked on. Happy if you want to add useful parts and if you have suggestions for the CI/CD, as I haven't set that up yet.

leifdenby commented 7 months ago

Great, I'll make a pull-request