Open Cri-dei opened 4 months ago
Hi, I filled everything! Let me know if it is correct now. Thank you!
Hi Mattia good morning, I tried and it works. Thank you so much! I try to open an issue to ecmwf github, I hope now I did all correctly, sorry for the wrong open issues of yesterday.
Please make sure that the notebook name is correct.
If you need to make modifications (e.g., to address the reviewer's comment), please share here the new version of the notebook and I will provide a new permalink.
Let me know when the notebook is accepted, I will merge the PR into main.
Please follow all the instructions shown when you open an issue. I noticed you did not add the environment info.
Go to the VM (or where you've executed your NB) and run conda env export
. Then, edit your very first comment of this issue and paste the environment info printed on the VM.
Hi @Cri-dei,
Unfortunately there's a (small) issue with this notebook.
There's a breaking change in the CDS forms. See: See: https://cds.climate.copernicus.eu/cdsapp#!/dataset/satellite-lake-water-level?tab=form You are not getting this issue on the old VM because we already cached the old request, but your notebook will break when we'll migrate to the new VM and/or the cache will expire.
The template of this notebook is already fixed. Could you please apply this change to your notebook and re-run it https://github.com/bopen/c3s-eqc-toolbox-template/commit/f220ca0f863e291b41a7710a18b274f92cec8dd8 Basically, you just need to add a few parameters to the request.
Also, very likely you'll get a dask error with the new data. The fix is very easy though. Could you please apply this change as well?
- da = download.download_and_transform(collection_id, request)[varname]
+ da = download.download_and_transform(collection_id, request)[varname].compute()
Hi Mattia, I think I upload the wrong zip file. This should contain the right version. I added all that changes.
Hi @Cri-dei,
Looks good. However, this is missing:
import numpy as np
Would you like to submit a new version?
Okay! I added that, hope now it is all fine. Here the attached version: LakeWaterLevel_Extremes.zip
I open a new issue and do it all again?
Nope, no need to open a new issue. I'll send you the permalink in the afternoon, I'm not on my laptop right now.
Hi @Cri-dei,
I've aligned the notebook with the latest template. If you check the preview, you'll notice some minor formatting edits. If you need to review this notebook, please make sure to start from the latest version.
Here is the latest permalink: https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/blob/2a632b36cfb5b0ae45f094b74217fb26b79e1c3b/Satellite_ECVs/Land_Hydrology/satellite_satellite-lake-water-level_climate-and-weather-extremes_q01.ipynb
You don't need to re-submit the permalink; the last one you used is still valid.
Also, it was decided to split the Land Hydrology and Cryosphere folders, I assume this notebook belongs to the former.
Data Type
Satellite ECVs - Land Hydrology & Cryosphere
Assessment Category
Climate And Weather Extremes
Dataset Name
satellite-lake-water-level
Question Number
1
Workflow ID
eqctier3-0001ffaa-5494-4cd6-aa72-4808e21dde23
Zipped Notebook
LakeWaterLevel_Extremes.zip
Environment
Anything else we need to know?
No response