Open virginiaciardini opened 8 months ago
Here is the permalink: https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/blob/b16535afd1ccec57b061da486feb63212d6de6c7/In_Situ/insitu_insitu-observations-gruan-reference-network_variability_q01.ipynb
Please make sure that the notebook name is correct.
If you need to make modifications, please share here the new version of the notebook and I will provide a new permalink. Let me know when the notebook is accepted, I will merge the PR into main.
Hi @virginiaciardini,
I got the email for an update but I guess you deleted the message? No worries if that's the case, I just wanted to make sure that you did it on purpose.
Hi @malmans2, I revised the JN and made some changes. Please find attached the new version. Could you provide me with a new permanent link? As you can see in the JN, a warning appears. How can I solve it? Thank you. C3S_520_Quality_assessment_Template_gruan_uq1_v4_rev_1.zip
Virginia
Here is the new permalink: https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/blob/840a5f7f10db1a1e381dccb8c63e2b4bea99b627/In_Situ/insitu_insitu-observations-gruan-reference-network_variability_q01.ipynb
As you can see in the JN, a warning appears. How can I solve it?
I think it's OK as it's clear why the warning is issued (there's missing values in the timeseries). If you or the reviewer want to silence that warning, please open an issue here and I'll show you how to do that.
Hi @malmans2 I will let you know whether or not it is necessary to silence the warning. Thanks, Virginia
Hi @virginiaciardini,
I noticed that in your notebooks there's a new deprecation warning. Basically, xarray
is deprecating the method drop
in favour of drop_vars
. Next time you request a permalink, please remember to substitute drop
with drop_vars
.
I already did it in the template you've been using. See https://github.com/bopen/c3s-eqc-toolbox-template/commit/9bd6f664e5c489bcb5a48bb1fc5dde9c0afca825
Hi @malmans,
ok. thanks, Virginia
Hi @malmans2, I revised again the JN and made some changes, using the new template. Please find attached the new version. Could you provide me with a new permanent link? Thank you. Virginia
insitu-observations-gruan-reference-network_variability_q01_rev.zip
Hi @virginiaciardini,
This notebook was submitted a long time ago, before the workflow ID was clearly shown in the CIM.
Could you please send me the workflow ID? It looks like this: eqctier3-1123e4567-e89b-12d3-a456-42665544000
Hi @malmans2, here the workflow ID
eqctier3-9cf3bf5d-61a7-4717-8f19-9f6aa0f5da26
thank you
Thanks! I only hade to make a minor change. The GCOS Reference Upper Air Network (GRUAN)
can not be a level 4 header as you can't jump from H2 to H4. I.e., it is this now: ### The GCOS Reference Upper Air Network (GRUAN)
I'll send you permalink and preview in a minute.
Perfect! thanks
Please ensure that the notebook name is correct. If you need to make any modifications (e.g., addressing the reviewer's comments), please share the new version of the notebook here, and I will provide a new permalink. Let me know once the notebook is accepted, and I will merge the PR into the main branch.
Hi @malmans2, May I ask you for a new link? minor changes are required
Thanks, Virginia
insitu-observations-gruan-reference-network_variability_q01_rev.zip
Hi @malmans2, I'm sorry but again minor changes are required. Can I ask you for a new link?
Thanks, Virginia
insitu-observations-gruan-reference-network_variability_q01_rev.zip
Data Type
In Situ
Assessment Category
Variability
Dataset Name
insitu-observations-gruan-reference-network
Question Number
1
Workflow ID
eqctier3-9cf3bf5d-61a7-4717-8f19-9f6aa0f5da26
Zipped Notebook
C3S_520_Quality_assessment_Template_gruan_uq1_v4.zip
Environment
Anything else we need to know?
No response