Open vincenzodetoma opened 1 month ago
I assume I can close #66?
Also, I think something is not right. Why is the workflow ID of this notebook the same as #199? I thought each notebook was supposed to be in separate workflows now.
Also, I think something is not right. Why is the workflow ID of this notebook the same as #199? I thought each notebook was supposed to be in separate workflows now.
I copy pasted the workflows from the old issue, where the workflow was unique. We are not able to see the tasks because they went to the data provider after the splitting. Shall we re-open issues? In case yes, you can close all our SST issues, and we'll reopen them with the correct workflow id. Sorry for this oversight! @dcianicnr83 Do you see something in the CIM?
Sorry, I'm a little lost. Do you have access to the unique workflow ID for each notebook? We can not open PR with multiple notebooks anymore.
If you have it, you can just edit the workflow ID you provided in the form. Let me know when you are done, I don't get notifications for edits.
Hi @vincenzodetoma,
How would you like to proceed? Are you able to get the correct workflow ID from the CIM?
Hi @malmans2, unfortunately still not. @dcianicnr83 asked for the reopening of all his tasks, but there were no answers yet. We'll come back to you as soon as we'll have something to work on. Thanks for your patience!
OK, if you need to speed up the process we can use the old ones and we'll fix it at the next round of review.
Hi @malmans2, @dcianicnr83 we have modified the workflow id editing the issue opening form above. Thanks!
I had to make a couple of fixes: You can only use H1 for the title, and one of the reference was not formatted correctly. See: https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/pull/207/commits/dd31f4cf090ad1642ee9f8d6285b3ffdddd475db
I will share the permalink in a minute.
Please ensure that the notebook name is correct. If you need to make any modifications (e.g., addressing the reviewer's comments), please share the new version of the notebook here, and I will provide a new permalink. Let me know once the notebook is accepted, and I will merge the PR into the main branch.
All set. All notebooks had the same issues. Please start from the latest permalink if you are going to have another round of review.
Dear @malmans2, with @dcianicnr83 we modified the notebook according to reviewer's suggestions. We ask thus for a new permalink. Thanks for your help and support! We also kindly ask you to close #198 #200, as agreed with @chunxueyang after internal discussion. Thanks! satellite_esacci_gmpe_monitor_q1_new.ipynb.zip
I found two issues in the notebook:
# Methodology
).[[5]](trenberth_nino_2020)
. The target must be an URL.I fixed both of them, please start from the correct version if you'll need to revise the notebook.
Data Type
Satellite ECVs - Ocean
Assessment Category
consistency
Dataset Name
satellite-sea-surface-temperature
Question Number
01
Workflow ID
eqctier3-8d67bc13-71c2-4aa1-b1bb-e7805302e724
Zipped Notebook
satellite_esacci_gmpe_monitor_q1_new.zip
Environment
Anything else we need to know?
Hi @malmans2, we (myself and @dcianicnr83) updated the notebook in #66 to match the new assessment categories and notebook template. Can you please provide us with a permalink and preview? Thanks