Closed sandrocalmanti closed 1 week ago
Please make sure that the notebook name is correct.
If you need to make modifications (e.g., to address the reviewer's comment), please share here the new version of the notebook and I will provide a new permalink.
Let me know when the notebook is accepted, I will merge the PR into main.
Dear Mattia,
We have modified the NB to incorporate reviewer's comments and we need a new permalink. Here, the zipped file: C3S_520_D5_3_15_ozone-recovering_v2.ipynb.zip
Thank you
Dear @malmans2 here's another revision of the ozone notebook after additional comments from ECMWF
Hi @malmans2 authorship acknowledgment and fixed typos in this update. Approved by Joao, should now go to data providers.
Hi @sandrocalmanti,
If I'm understanding correctly the workflow, this notebook is still under review (data providers need to review it?), so we cant't merge the PR into main yet. Correct? If yes, let me know when you get the final approval.
Dear @malmans2,
finally managed to respond to the feedbacks from data provider. Here's the updated notebook.
Hi @sandrocalmanti,
Could you please send me the workflow ID of this notebook? The issue was opened a long time ago, when the IDs were not explicitly shown in the CIM.
Sure.
Workflow: eqctier3-dc76e555-df09-41ff-82fb-2a3d04ce221a
Hi @sandrocalmanti,
Please have a look at the latest template and instructions: https://ecmwf-projects.github.io/c3s2-eqc-quality-assessment/templates/template_instructions.html#methodology The section references were not formatted correctly. Here are the changes I made: https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/pull/191/commits/366cce4c8c35fff1a36f73c8e23a7fe62b9e1c8e
I will share the new permalink and preview in a minute.
I also had to remove the logo in the first cell. The notebook you submit should start with the title and no logo, as it is added automatically when we build the book.
Please ensure that the notebook name is correct. If you need to make any modifications (e.g., addressing the reviewer's comments), please share the new version of the notebook here, and I will provide a new permalink. Let me know once the notebook is accepted, and I will merge the PR into the main branch.
Thank you @malmans2 I will pay attention to these formatting bits in the next implementation.
Question: is there a way to get rid of the retrieval progress bars? Should they be there?
We could add the hide-output
tag to that cell.
See:
Let me know if you want to share a new notebook, or you want me to add the tag. Either way works for me.
Trying to re-run with the hide-output tag.
You don't need to re-run the notebook. The tag does not affect the notebook, it only affects the final jupyter books.
You also have the option to deactivate the progress bar at run time. This is the syntax you'd have to use:
download_and_transform(..., quiet=True)
I have fixed some additional formatting here (icons in the section headers and assessments statements)
I also implemented the fixes you have shared about section links and image at the top directly on my version, just to check that the rendering on the new VM is working smoothly.
I have put the download and transform to the quiet mode.
This version should work.
Data Type
Satellite ECVs - Atmospheric Composition
Assessment Category
Climate Monitoring
Dataset Name
satellite-ozone-v1
Question Number
1
Workflow ID
eqctier3-dc76e555-df09-41ff-82fb-2a3d04ce221a
Zipped Notebook
C3S_520_D5_3_15_ozone-recovering.zip
Environment
Anything else we need to know?
No response