Open almarbo opened 3 months ago
Here is the permalink: https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/blob/32cb90e2f830caadafd0266b516ab8fa73921f09/Climate_Projections/climate_projections-cmip6_climate-impact-indicators_q03.ipynb
Please make sure that the notebook name is correct.
If you need to make modifications (e.g., to address the reviewer's comment), please share here the new version of the notebook and I will provide a new permalink.
Let me know when the notebook is accepted, I will merge the PR into main.
hi @malmans2 , I have edited the notebook to address the first data provider's reviews. Even if there will be more reviews and updates, I would like to ask if you could provide a new permalink. The main reason is that we have transitioned from a large notebook composed of sub-notebooks to individual notebooks, and we want to include them all in CIM. Thanks.
hi @malmans2 , I have updated the notebook including revisions, could you provide a new permalink?
Hi @malmans2 I do not know why but two things that I did not expect occur when I open the permalink. First of all, the embedded image is not showing (I attached it as shown in the template and I am able to see it if I open the Jupyter notebook from another computer). Secondly, the last section "3.6. Results summary and discussion" as well as "If you want to know more" is not showing. If I download the provided zip (the last one that I updated) and extract the notebook from there everything looks fine. I do not know why this is happening. What I have just noticed are slight differences between the last markdown cell before the section "disappearing" from this notebook and the exact same markdown cell from another notebook working properly (e.g. https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/blob/4655b22bc9a5b9c1405c5fa107c9ddeafdea2a48/Climate_Projections/climate_projections-cmip6_climate-and-weather-extremes_q01.ipynb)
Do you have any clues on this?
I can try making the markdown cell to be exact like the one from the Jupyter notebook working and then see if the problem persists.
The first one is easy.
I believe you should use markdown, something like this: ![test_img.png](attachment:4cf358c8-5758-431e-bf74-dc6fdcc4e88f.png)
It looks like you are using some HTML code instead. What's the template you are following?
Not sure about the second one, I'll take a look either later today or tomorrow. Let me know if you find a solution before I do.
I see, the use of HTML is shown in the template. Please use markdown if possible, I have a meeting tomorrow with ECMWF and I'll bring this up.
I am using the simple template:
Simple alternative with html (width controlled via width="300px" as needed, to use an attachment, relace the test_img.png with the 'attachment:...'):
About the second, I have updated the notebook with what I think it might be the problem solved. If you could provide a new permalink or somehow let me know if it works it would be nice
Didn't see your comment sorry. I am using HTML because it allowed adjusting the size.
hi @malmans2 , I confirm that I have found what was wrong and the reason why the last section disappeared. It was an html detail when playing with the format of the caption of the last figure:
<div>
instead of
</div>
At this point, I don't know if it makes sense creating a new permalink or wait until we find a solution for the embedded figure. I remember that providing also the image in the zip was said to be an option. Is this still an option?
The template/workflow is being revised to address various issues, including this one. Is your reviewer Chris Goddard? If yes, you can probably leave it as it is. He is up to speed with the latest discussions about this. Otherwise, you should probably ask CNR what's the best way to proceed.
Chris is my reviewer indeed and we'll be in touch. Thanks for the update!
hi @malmans2 , I have updated the notebook including the data provider last revisions, could you provide a new permalink?
Data Type
Climate Projection
Assessment Category
Climate Impact Indicators
Dataset Name
projections-cmip6
Question Number
1
Workflow ID
eqctier3-6cea0c38-0a26-4b6e-8673-d8349bf10b9d
Zipped Notebook
climate_projections-cmip6_climate-impact-indicators_q01.zip
Environment
Anything else we need to know?
No response