Open almarbo opened 4 months ago
Here is the permalink: https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/blob/32cb90e2f830caadafd0266b516ab8fa73921f09/Climate_Projections/climate_projections-cmip6_climate-and-weather-extremes_q01.ipynb
Please make sure that the notebook name is correct.
If you need to make modifications (e.g., to address the reviewer's comment), please share here the new version of the notebook and I will provide a new permalink.
Let me know when the notebook is accepted, I will merge the PR into main.
hi @malmans2 I have edited the notebook to address the first data provider's reviews. Even if there will be more reviews and updates, I would like to ask if you could provide a new permalink. The main reason is that we have transitioned from a large notebook composed of sub-notebooks to individual notebooks, and we want to include them all in CIM. Thanks.
Hi @almarbo,
The workflow ID you shared doesn't look right.
The Workflow ID is explicitly shown in the CIM. It looks like this: eqctier3-1123e4567-e89b-12d3-a456-42665544000
Could you please provide the right ID in all issues you've opened? Let me know here when you fixed all of them.
really? I actually took it from CIM (when it was called task id) and I have not changed it from the first time I opened the issue, I guess they have changed it. Anyway, thanks for letting me know and I will provide the corrected workflow ID once CIM is working again.
Yes, you shared the Task ID but we need the Workflow ID as it is permanent. Predictia recently added a box that clearly shows the Task and Workflow ID, so it should be easy to find.
hi @malmans2 , I have updated the notebook including revisions, could you provide a new permalink?
hi @malmans2 , I have updated the notebook including the data provider last revisions, could you provide a new permalink?
Hi @almarbo,
Although the latest template/instructions have not been share yet, it was decided to use MyST syntax to handle section references. This is the new syntax, which is much easier:
**[](section-1)**
* [](section-1.1)
* [](section-1.2)
* [](section-1.3)
* [](section-1.4)
* [](section-1.5)
* [](section-1.6)
**[](section-2)**
* [](section-2.1)
* [](section-2.2)
* [](section-2.3)
**[](section-3)**
* [](section-3.1)
* [](section-3.2)
* [](section-3.3)
* [](section-3.4)
* [](section-3.5)
* [](section-3.6)
Then explicitly label all sections. For example:
(section-1)=
## 1. Parameters, requests and functions definition
I've applied this change to this notebook just to show how to use it. Could you please implement this change in all your notebooks? Let me know when you are done.
Here is the example: notebook-with-myst-syntax.zip
hi @malmans2 . I have a couple of questions. I guess that I can and I should add the text of the sections inside the brackets []
, right? The second question is if the hyperlinks also work for Jupyter lab or only for html and Jupyter book, because right now It does not work for me. For example if I click here it does not bring me to the section 3
**[3. Plot and describe results](section-3)**
Also, will the "section-1" be visible? or will be hidden?:
(section-1)=
## 1. Parameters, requests and functions definition
Thank you
I guess that I can and I should add the text of the sections inside the brackets [], right?
No, just leave empty brackets. It will be rendered automatically inferring the text. The example I sent you is already in good shape.
The second question is if the hyperlinks also work for Jupyter lab or only for html and Jupyter book, because right now It does not work for me.
It works for jupyterlab as well as long as you install the myst parser (i.e., install jupyterlab-myst
). It's already installed on the VM, so if you use that one it should work correctly.
Also, will the "section-1" be visible
It will be hidden (although it is visible in the permalink because GitHub does not use the MyST parser)
super! thanks a lot. Is there some updates regarding the embedded figure?
Yes, you must use attachments and you can use MyST syntax (but not pure HTML). The new instructions are here (although I'm not sure they've been shared with the evaluators yet...)
Maybe just send me one notebook with your edits before doing the same to all of them. I'll make sure everything is in good shape.
Okey thanks a lot!
I send you the corresponding to this issue:
climate_projections-cmip6_climate-and-weather-extremes_q01.ipynb.zip
There's another problem. You can't have two titles in the same notebook:
# Analysis and results
Analysis and results can not be a level one header. You should either remove it or use ## Analysis and results
. If you do the latter, you should also lower the level of the next headers. For example:
## Analysis and results
(section-1)=
### 1. Parameters, requests and functions definition
Hi @malmans2
I have already adressed your comment. Is this notebook already in good shape or something is missing or need to be changed?
climate_projections-cmip6_climate-and-weather-extremes_q01.zip
thanks
Yup, this one you sent today looks good. Please send me all your other notebooks in their issues. I will process all of them together and will send you the permalinks and previews.
Hi @malmans2 , this notebook and the rest of CMIP6 and CORDEX have been updated (issues #91 #92 #47 #95 #96 #32 #93 #40 #94 )
Hi @almarbo,
You had a few errors in most notebooks, mainly due to wrong references in the text (see https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/pull/102/commits/61ed6d347dc7aa7646d5c98764979a94a0aa8c01). I fixed them myself, so please start from the permalink version next time. I'm going to share all permalinks in a minute.
There were a few issues with the CORDEX notebooks as well. See: https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/pull/101/commits/e1688e22eaa9ee2acd72fdfb891944a7dc750c4b
Also, I had to remove a reference to a CMIP6 notebook. CMIP6 and CORDEX live in different branches, so you can add cross-references only after one of them is approved and merged.
Oh! Thanks for noticing these issues. The references to other notebooks were discussed with Chris. In fact, we decided to mention other notebooks but not reference them directly for now. I did this for the rest, but I missed removing the reference to the CMIP6 notebook in that particular case. Thanks for noticing.
OK, you might want to remove some cross references then. I kept the references to notebooks in the same branches, I just fixed them by point to the correct file.
Data Type
Climate Projection
Assessment Category
Climate And Weather Extremes
Dataset Name
projections-cmip6
Question Number
1
Workflow ID
eqctier3-6cea0c38-0a26-4b6e-8673-d8349bf10b9d
Zipped Notebook
climate_projections-cmip6_climate-and-weather-extremes_q01.zip
Environment
Anything else we need to know?
No response