Open paolocristofanelli opened 6 months ago
Hi @paolocristofanelli,
Please edit your message and add the environment details as explained in the form (copy/paste the output of conda env export
).
Please make sure that the notebook name is correct.
If you need to make modifications (e.g., to address the reviewer's comment), please share here the new version of the notebook and I will provide a new permalink.
Let me know when the notebook is accepted, I will merge the PR into main.
@paolocristofanelli as you can see the figures in your markdown are not rendered. You can not point to external/local files in your notebook as we only upload notebooks here.
If you want to add figures, you need to include the in the markdown (for example, you can drag and drop the figure in the markdown).
Ciao @malmans2. The issue has been updated with environment info as well as the JN by dragging the figure in the markdown. Hope it's fine now. If not just let me know!
Hi @paolocristofanelli,
I tested this notebook on the new VM (I'm populating the cache), but it looks like the version you uploaded here is broken.
For example, the function compute_mann_kendall_trend
that you use in compute_anomaly_trends
is not defined. You probably don't get errors on the old VM because you are using cached data. To invalidate the cache you can pass the argument invalidate_cache=True
in download_and_transform
.
I checked and the template I made for you, and all functions are properly defined: https://github.com/bopen/c3s-eqc-toolbox-template/blob/main/notebooks/wp5/xch4_xco2_satellite_lev3.ipynb
Could you please revise your notebook using the code in the template? Let me know if anything is not clear.
Hi @malmans2 !
You're right (of course). I tried to simplify the notebook by removing the reference to variable "ch4" but I was not effective, indeed. Here the revised version (not removing references to "ch4"). Should work now. Can we use the previous permalink or we need a new one?
You are going to need a new permalink anytime you make modification, but I guess you can wait until the next round of review to share a new link in the CIM.
Anyways, I've uploaded the latest version on GH and here is the permalink: https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/blob/1a64eecdd8e513fb9e582063c620406b8fb837c2/Satellite_ECVs/Atmospheric_composition_ECVs/satellite_satellite-carbon-dioxide_trend-assessment_q01.ipynb
I haven't test it yet on the new VM as it's under maintenance, I will let you know when I do it.
The latest version of the NB works fine on the new VM as well. No further action is needed. Thanks!
Ciao @malmans2 , here you can find the JN revised by the data provider. Please can you create a permalink?
@paolocristofanelli did you delete your last comment? I received an email notification yesterday but your last comment is dated July 8th.
Yes Mattia. I deleted the issue!
Hi there,
I've aligned the notebook with the latest template. If you check the preview, you'll notice some minor formatting edits. If you need to review this notebook, please make sure to start from the latest version.
Here is the latest permalink: https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/blob/d53fecd6a1c84644be5b0d9b73653e459a2b9956/Satellite_ECVs/Atmospheric_Composition/satellite_satellite-carbon-dioxide_trend-assessment_q01.ipynb
You don't need to re-submit the permalink; the last one you used is still valid.
Data Type
Satellite ECVs - Atmospheric Composition
Assessment Category
Trend Assessment
Dataset Name
satellite-carbon-dioxide
Question Number
1
Workflow ID
bf401899-dd68-11ee-8810-5279ad638b32
Zipped Notebook
satellite-observations_carbon-dioxide-data-from-2002-to-present-derived-from-satellite-observations_completeness_q1.zip
Environment
Anything else we need to know?
No response