Open gmandorl opened 5 months ago
Hi @gmandorl ,
1123e4567-e89b-12d3-a456-42665544000
conda env export
Please add the missing information in your comment above and let me know when you've done it.
Hi @gmandorl, from a quick look at the notebook you attached I see you're assessing if the satellite data you are analyzing is able to reproduce a well known relation from literature. Then I would say your use case falls into 'consistency assessment' assessment category. If you think it's not, would you like to suggest a different category for your use case? I'm not sure but I think we can manage to create a general enough new category (they are conceived to be widely applicable for different use cases / user questions)
@malmans2 Thank you for the instructions. I updated Assesment Category and Environment. However, I just realized that I don't have that entry in CIM anymore. I will try to get it back and I will update this request. In addition, where is the issue template?
@vincenzodetoma thank you very much. Isn't it the most frequent category?
The issue template is what you see when you open an issue (i.e., the form with instructions)
I see the instruction for the Environment now. I am very sorry I did not see it before
No worries. I edited your env info so they are collapsable. Let me know when you have the Workflow ID so I can issue the permalink.
@malmans2 Thank you for the instructions. I updated Assesment Category and Environment. However, I just realized that I don't have that entry in CIM anymore. I will try to get it back and I will update this request. In addition, where is the issue template?
@vincenzodetoma thank you very much. Isn't it the most frequent category?
@gmandorl, depends. For now the most visited are the ones like trend assessment, consistency assessment, climate and weather extremes, climate monitoring.
@malmans2 I updated Assesment Category, Environment, and Workflow ID now. Can you generate the permanent link?
Please make sure that the notebook name is correct.
If you need to make modifications (e.g., to address the reviewer's comment), please share here the new version of the notebook and I will provide a new permalink.
Let me know when the notebook is accepted, I will merge the PR into main.
Hi @gmandorl,
I'm running this notebook on a new VM as I'm pre-populating the cache to get ready for the migration.
I found a small issue. Most of CDS datasets that accept the area parameter use this convention for coordinates: [N, W, S, E]
. However, you are using [S, W, N, E]
.
It looks like the CDS recently changed the form of the dataset you are using, and only [N, W, S, E]
is now allowed. You are not going to see this breaking change on the old VM because the data is already cached, but you'll experience it in the future.
I changed this line in your code, and I'm getting the same results:
datasets = {}
for collection_id in requests :
request = requests[collection_id]
datasets[collection_id] = download.download_and_transform(
collection_id,
- download.update_request_date(request | {'area': [lat_min, lon_min, lat_max, lon_max]},
+ download.update_request_date(request | {'area': [lat_max, lon_min, lat_min, lon_max]},
start,
stop,
stringify_dates=True),
chunks=chunks,
)
Could you please re-run your NB with this change and make sure that it works as expected? If everything looks OK, please implement the change in you NB next time you'll request a permalink. Also, did I make a template for this notebooks? If yes, I can't find it: Could you please send me the URL?
Hi @malmans2,
I just run the notebook and it works as expected: the configurations [S, W, N, E] and [N, W, S, E] produce the same results. Should I do something when moving to the new VM?
There is a template for this notebook on: https://github.com/bopen/c3s-eqc-toolbox-template/issues/150 but I modified the notebook after your corrections.
OK, I'll make sure the template uses the latest CDS form. No need to do anything when we'll migrate. Just make sure you implement the change above when you'll request a new permalink.
You can also send me the NB with the fix now, it's up to you. I'll store it on GitHub and will provide the latest permalink.
I will send you the new fixed NB when I receive the comments from the data providers.
Data Type
Satellite ECVs - Atmosphere Physics
Assessment Category
Consistency Assessment
Dataset Name
satellite-total-column-water-vapour-land-ocean
Question Number
1
Workflow ID
748d757e-0d10-11ef-a43b-fa90f00e9db9
Zipped Notebook
Hi,
I am not sure of where to find the Workflow ID and I am also unclear on the Assessment Category for this particular use case.
satellite_satellite-total-column-water-vapour-land-ocean_validation_q1.zip
Environment
Anything else we need to know?
No response