Open dcianicnr83 opened 4 months ago
Please make sure that the notebook name is correct.
If you need to make modifications (e.g., to address the reviewer's comment), please share here the new version of the notebook and I will provide a new permalink.
Let me know when the notebook is accepted, I will merge the PR into main.
Hi @malmans2,
thanks for providing the permalink. I noticed I have an error message if I try to access the notebook via the permalink (please see image in attachment). Is it normal? Thanks
Today GitHub has problems rendering jupyter notebooks. It's not related to this project, but it's an issue in GitHub (e.g., see https://github.com/orgs/community/discussions/124651).
Predictia implemented a custom rendering of notebooks in the CIM, therefore the CIM is not affected.
Thank you so much @malmans2 for clarifying
Hi @malmans2 , we worked with @vincenzodetoma to produce a new version of the notebook with the new template. Please find it in attachment. satellite-sea-surface-temperature-ensemble-product.zip
Hi @malmans2, with @dcianicnr83 we revised the notebook according to Joao comments. We still need your help because of a main issue: we noticed that masking is not properly working, since we expect that if a pixel has sea-ice at least in one timestep of the series, it should be masked out. See the attached image from this publication. Is it possible to solve? I think there must be some internal function in doing the reductions which calculates anyway a result when there are nans, doing it on a smaller number of elements.
Is it possible to solve this?
The other thing is a comment which requires to extend only the time series in the attached notebook till 2016. I introduced an additional variable year_stop_ts which can control this, but I am not able to run it again.
Here I attach the zipped notebook.
Thanks!
OK, I'll take a look tomorrow.
In principle, you can achieve what you need with the argument skipna=False
.
Hi @malmans2, I tried but the kernel dies after the first year of calculation in the mean. In any case, Thanks for the suggestion :)
Very likely someone did not close a memory intensive nb. I'll look at this later this morning.
I'm caching it. I can't remember how long it takes to run the whole NB, probably a few hours at least. I'll let you know when it's ready and will share the latest version.
Oh I remember now, this is a heavy one that takes time. It's still running, I'll ping you when it's done.
@vincenzodetoma quick update: There was some issue with the CDS over the weekend and I was not able to download the new data. It looks like it's fixed now, so I'm re-trying to cache the notebook.
Hi @malmans2, no problem :) Thanks!!!
Here it is: satellite_esacci_gmpe_monitor_q1.zip
Let me know if it works OK
Hi @malmans2, here it is. Of course, this is also the revision for #66. @dcianicnr83 will do the final check and paste the link in the CIM. Thanks a lot for your precious support!! satellite_esacci_gmpe_monitor_q1_26062024.zip
Thanks @malmans2. Side question: is there also the preview for the rendering in the book available?
Yes, however, it's not clear to me whether I can share it with evaluators or not yet. Anyways, you've been involved in the discussions, so you know what's going on. You can find it in the PR linked to this issue (see the top right bar of this issue, under Development).
BTW, is this notebook going to be the same used in #66? If yes, please upload it there as well
@malmans2 I noticed that in the book preview under the method section, links are properly working only for section 3. Did I made some mistake? Can you make or suggest a fix for this?
I believe they are all typos:
+ import-packages-and-define-parameters-for-the-requests-to-the-cds
- import-packages-and-define-parameters-for-the-request-to-the-cds
+ define-functions-to-cache
- define-function-to-cache
+ plot-annual-maps-bias-seasonal-maps-and-timeseries-with-discussions
- plot-annual-maps,-bias,-seasonal-maps-and-timeseries,-with-discussion
satellite_esacci_gmpe_monitor_q1_26062024.ipynb.zip Hi @malmans2, I've corrected accordingly. Should be working properly now! Thanks again! I will upload also in #66
Data Type
Satellite ECVs - Ocean
Assessment Category
Climate Monitoring
Dataset Name
satellite-sea-surface-temperature-ensemble-product
Question Number
01
Workflow ID
eqctier3-1a3a89e7-8635-48db-a3c6-ceb4b7fdfc87
Zipped Notebook
satellite_esacci_gmpe.ipynb.zip
Environment
Anything else we need to know?
No response