Open gmandorl opened 5 months ago
Hi @gmandorl,
That doesn't look like the right Workflow ID. The workflow ID is now explicitly shown in the CIM and it looks like this: eqctier3-1123e4567-e89b-12d3-a456-42665544000
Could you please edit your comment with the correct ID. Let me know when you've done it.
Hi @malmans2,
I am sorry, that was the Task ID. I just updated the my comment with the correct workflow ID.
Here is the permalink: https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/blob/2d5acec44b288e2958cf06972fbaae9700fe573f/Satellite_ECVs/Atmosphere_Physics_ECVs/satellite_satellite-precipitation_uncertainty_q01.ipynb
Please make sure that the notebook name is correct.
If you need to make modifications (e.g., to address the reviewer's comment), please share here the new version of the notebook and I will provide a new permalink.
Let me know when the notebook is accepted, I will merge the PR into main.
I modified the notebook to address the reviewer's comments. The new notebook is
satellite-observations_satellite-precipitation_validation_q01.zip
Hi @gmandorl,
This notebook also has the same issue explained in https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/issues/64#issuecomment-2133617771 You need to implement this change:
- 'area': [lat_min, lon_min, lat_max, lon_max],
+ 'area': [lat_max, lon_min, lat_min, lon_max],
Hi @malmans2 ,
I think that almost all my notebooks have that issue.
However, I don't need to change it immediately because I don't have the CIM entries anymore. When I will receive the feedback from the data providers I will share a new JN with their corrections, and I will also correct this issue.
Sure, no problem. I'm dealing with a ton of notebooks so I'm writing anything that needs to change to keep track of it. So I'll probably write this again in other issues.
Data Type
Satellite ECVs - Atmosphere Physics
Assessment Category
Uncertainty
Dataset Name
satellite-precipitation
Question Number
1
Workflow ID
eqctier3-767b1bcd-e6f0-4df3-aa9f-b0aa50c1df4d
Zipped Notebook
satellite-precipitation_validation_q1.zip
Environment
Anything else we need to know?
No response