Open ritavcunha opened 6 months ago
Hi @malmans2 ,
It seems that I put the Workflow ID wrong. This is the correct one: eqctier3-12f4a033-8bc6-4209-a4db-a68d73f13b61
Here is the permalink: https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/blob/9603d2abb15a2849d744ea052b160bf8963e6c96/In_Situ/insitu_insitu-gridded-observations-europe_climate-monitoring_q03.ipynb
Please make sure that the notebook name is correct.
If you need to make modifications (e.g., to address the reviewer's comment), please share here the new version of the notebook and I will provide a new permalink.
Let me know when the notebook is accepted, I will merge the PR into main.
Hi @ritavcunha,
I was caching this notebook on the new VM and I noticed that you submitted a notebook with no output. Was that intended?
Hi @malmans2 ,
Yes, the notebook is without outputs, just because the download of ERA5 is very slow, and we had to advance with the notebook code itself.
Thank you for the remark.
Best regards, Rita
Hi @malmans2,
We had to make some minor changes.
Here is the new zip file: C3S2_D520.5.3.14b_Quality_Assessment_User_Questions_EOBS_UQ3_v1.4.zip
Best regards, Rita Cunha
Hi @malmans2 ,
So the new workflow ID, for Use Case 3 is: Task: 1c557858-5fd9-11ef-8af3-c24173f93b26 Workflow: eqctier3-74179ca0-6a1b-4e5d-a3c4-0f113978a2b3
Regarding the figure, I didn't attach any.
The new zip file is this one (without the logo and the warning): C3S2_D520.5.3.14b_Quality_Assessment_User_Questions_EOBS_UQ3_v1.5.zip
I'm sorry for any inconvenience.
Best regards, Rita Cunha
Hi there,
A few issues in this notebook as well:
4. Calculate the Probability density function (PDF)
was wrong (you had a typo, you had section-1 in the tag)Work in progress
must be one level down the header above (i.e., #### Work in progress
)I fixed the issues myself, I'll share the links in a minute.
Please ensure that the notebook name is correct. If you need to make any modifications (e.g., addressing the reviewer's comments), please share the new version of the notebook here, and I will provide a new permalink. Let me know once the notebook is accepted, and I will merge the PR into the main branch.
Hi @malmans2 ,
We needed to make minor changes regarding the layout of the notebook.
Here is the new zip file:
C3S2_D520.5.3.14b_Quality_Assessment_User_Questions_EOBS_UQ3_v1.6.zip
Best, Rita
Hi @ritavcunha,
It looks like this notebook is not aligned with the latest template. For example, the Analysis and results
section is missing. Also, you should not include the note on top, that's an internal note for evaluators only.
Hi @malmans2 ,
Sorry for the mistake here is the new zip file: C3S2_D520.5.3.14b_Quality_Assessment_User_Questions_EOBS_UQ3_v1.8.zip
Best, Rita
Hi @malmans2,
In order to implement all the requested changes, here is the new updated zip file of this Use Case: C3S2_D520.5.3.14b_Quality_Assessment_User_Questions_EOBS_UQ3_v1.12.zip
Best, Rita
@ritavcunha there's a couple of problems:
### 2. bla bla bla
and #### 2.1. bla bla bla
(code-section-2)=
Also, you don't need to hardcode the title in the Methodology section. This is done automatically. You can use the syntax shown in the template:
**[](section-1)**
* Sub-steps or key points listed in bullet below. No strict requirement to match and link to sub-headings.
**[](section-2)**
* Sub-steps or key points listed in bullet below. No strict requirement to match and link to sub-headings.
**[](section-3)**
* Sub-steps or key points listed in bullet below. No strict requirement to match and link to sub-headings.
**[](section-4)**
* Sub-steps or key points listed in bullet below. No strict requirement to match and link to sub-headings.
**[](section-5)**
* Sub-steps or key points listed in bullet below. No strict requirement to match and link to sub-headings.
As you can see brackets are empty, so if you change the title of a section in the future, the reference is also consistent with the new title.
Hi @malmans2 , you're right! I will revise and then forward to you again. Sorry for any inconveniente.
Best, Rita
Hi @malmans2,
Here is the new version. Please let me know if something else is needed. C3S2_D520.5.3.14b_Quality_Assessment_User_Questions_EOBS_UQ3_v1.13.zip
A few more issues, but I’ve addressed them:
Here is the permalink: https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/blob/5ed47390d27cf315d3c7698a0a2dc999c2783255/In_Situ/insitu_insitu-gridded-observations-europe_climate-monitoring_q03.ipynb
Data Type
In Situ
Assessment Category
Climate Monitoring
Dataset Name
insitu-gridded-observations-europe
Question Number
3
Workflow ID
eqctier3-74179ca0-6a1b-4e5d-a3c4-0f113978a2b3
Zipped Notebook
C3S2_D520.5.3.14b_Quality_Assessment_User_Questions_EOBS_UQ3_v1.3.zip
Environment
Anything else we need to know?
No response