search

ecmwf-projects / cads-api-client

CADS API Python client for developing and testing
Apache License 2.0
2 stars 2 forks source link

Add the _timestamp to the observations adaptor to detect regressions #55

Closed garciampred closed 1 month ago

manfredsc commented 1 month ago

Sorry for my drive-by comment, I did an issue report and saw this pull request. For distributions, this most probably would make builds non-reproducible. See also https://reproducible-builds.org. For c-code there are some tweaks to fake the date in distribution builds, but I don't think there are some similar measures for python. Dumping the version number, the git hash or the timestamp of the last check-in would be a lot more reproducible.

garciampred commented 1 month ago

Sorry for my drive-by comment, I did an issue report and saw this pull request. For distributions, this most probably would make builds non-reproducible. See also https://reproducible-builds.org. For c-code there are some tweaks to fake the date in distribution builds, but I don't think there are some similar measures for python. Dumping the version number, the git hash or the timestamp of the last check-in would be a lot more reproducible.

Thanks. That is interesting although not relevant here as this is python and it is not to be compiled. Also, these tests are now implemented here https://github.com/ecmwf-projects/cads-e2e-tests in a more elegant way, so there is no need to merge this. Regards.