search

ecmwf-projects / cads-api-client

CADS API Python client
https://ecmwf-projects.github.io/cads-api-client/
Apache License 2.0
4 stars 3 forks source link

API changed in patch version (1.3.1) #81

Closed BSchilperoort closed 1 month ago

BSchilperoort commented 1 month ago

In #69 the order of the arguments to cads_api_client.ApiClient changed (maybe unintentionally?).

Instead of (key, url), the order changed to (url, key). The changed code was released as part of version 1.3.1. This broke any other code that did not use the arguments as kwargs, such as era5cli (https://github.com/eWaterCycle/era5cli/issues/168).

malmans2 commented 1 month ago

Hi there, sorry about that! It was intentional to align with cdsapi. See: https://github.com/ecmwf-projects/cads-api-client/issues/75

Please not that at the moment cads-api-client is not stable.

BSchilperoort commented 1 month ago

Please not that at the moment cads-api-client is not stable.

The version number makes it seem like it would be. Could you add this disclaimer clearly in the README?