codecov-commenter
commented
10 months ago Codecov Report
Attention: 11 lines in your changes are missing coverage. Please review.
Comparison is base (
5ea733a) 79.40% compared to head (99d7ca0) 79.63%. Report is 2 commits behind head on develop.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #161 +/- ## =========================================== + Coverage 79.40% 79.63% +0.22% =========================================== Files 822 847 +25 Lines 62223 62714 +491 =========================================== + Hits 49410 49942 +532 + Misses 12813 12772 -41 ``` | [Files](https://app.codecov.io/gh/ecmwf/atlas/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf) | Coverage Δ | | |---|---|---| | [src/atlas/interpolation/Cache.h](https://app.codecov.io/gh/ecmwf/atlas/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-c3JjL2F0bGFzL2ludGVycG9sYXRpb24vQ2FjaGUuaA==) | `100.00% <ø> (ø)` | | | [src/atlas/mesh/MeshBuilder.cc](https://app.codecov.io/gh/ecmwf/atlas/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-c3JjL2F0bGFzL21lc2gvTWVzaEJ1aWxkZXIuY2M=) | `91.08% <100.00%> (+1.37%)` | :arrow_up: | | [src/atlas/mesh/MeshBuilder.h](https://app.codecov.io/gh/ecmwf/atlas/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-c3JjL2F0bGFzL21lc2gvTWVzaEJ1aWxkZXIuaA==) | `100.00% <100.00%> (ø)` | | | [...atlas/redistribution/detail/RedistributeGeneric.cc](https://app.codecov.io/gh/ecmwf/atlas/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-c3JjL2F0bGFzL3JlZGlzdHJpYnV0aW9uL2RldGFpbC9SZWRpc3RyaWJ1dGVHZW5lcmljLmNj) | `91.00% <100.00%> (ø)` | | | [...s/redistribution/detail/RedistributionInterface.cc](https://app.codecov.io/gh/ecmwf/atlas/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-c3JjL2F0bGFzL3JlZGlzdHJpYnV0aW9uL2RldGFpbC9SZWRpc3RyaWJ1dGlvbkludGVyZmFjZS5jYw==) | `100.00% <100.00%> (ø)` | | | [src/atlas\_f/atlas\_module.F90](https://app.codecov.io/gh/ecmwf/atlas/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-c3JjL2F0bGFzX2YvYXRsYXNfbW9kdWxlLkY5MA==) | `36.11% <ø> (ø)` | | | [...tests/mesh/fctest\_mesh\_triangular\_mesh\_builder.F90](https://app.codecov.io/gh/ecmwf/atlas/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-c3JjL3Rlc3RzL21lc2gvZmN0ZXN0X21lc2hfdHJpYW5ndWxhcl9tZXNoX2J1aWxkZXIuRjkw) | `100.00% <100.00%> (ø)` | | | [...rc/tests/mesh/test\_mesh\_triangular\_mesh\_builder.cc](https://app.codecov.io/gh/ecmwf/atlas/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-c3JjL3Rlc3RzL21lc2gvdGVzdF9tZXNoX3RyaWFuZ3VsYXJfbWVzaF9idWlsZGVyLmNj) | `100.00% <100.00%> (ø)` | | | [src/tests/redistribution/fctest\_redistribution.F90](https://app.codecov.io/gh/ecmwf/atlas/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-c3JjL3Rlc3RzL3JlZGlzdHJpYnV0aW9uL2ZjdGVzdF9yZWRpc3RyaWJ1dGlvbi5GOTA=) | `100.00% <100.00%> (ø)` | | | [...s\_f/redistribution/atlas\_Redistribution\_module.F90](https://app.codecov.io/gh/ecmwf/atlas/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-c3JjL2F0bGFzX2YvcmVkaXN0cmlidXRpb24vYXRsYXNfUmVkaXN0cmlidXRpb25fbW9kdWxlLkY5MA==) | `96.42% <96.42%> (ø)` | | | ... and [2 more](https://app.codecov.io/gh/ecmwf/atlas/pull/161?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf) | | ... and [168 files with indirect coverage changes](https://app.codecov.io/gh/ecmwf/atlas/pull/161/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fix compilation warning on handling interpolation matrices (MatrixCache is not fully implemeting the "rule of 5" so I've removed the triggering constructor, the others are sufficient)
Fix a logic error in the generic redistribution method, on detecting indices uniqueness.