Recent work on adding a halo size > 0 to atlas-orca (https://github.com/ecmwf/atlas-orca/issues/19) revealed an issue in the North fold of the orca grid when comparing MPI to non-MPI interpolations.
This issue was traced to the interpolator not properly accounting fully for the wrapping of the source interpolation mesh cell when it crosses the periodic boundary.
This change fixes this issue by properly validating each cell.
The change was proposed by Simon Good, I am just performing the necessary admin to get the change into atlas.
Testing
This is tricky to test, and requires a separate PR in atlas-orca to introduce a ctest to cover the issue.
Testing was performed using a combination build, as part of other changes associated with the move to halo size = 1. Regression tests against known-good-outputs was how the change was discovered, but this system is internal to the Met Office. The master pr for the coordinated change is https://github.com/MetOffice/orca-jedi/pull/96
An example of some of the affected interpolated points that were incorrect before this change and fixed afterwards on an eORCA025_T:
Description
Recent work on adding a halo size > 0 to atlas-orca (https://github.com/ecmwf/atlas-orca/issues/19) revealed an issue in the North fold of the orca grid when comparing MPI to non-MPI interpolations.
This issue was traced to the interpolator not properly accounting fully for the wrapping of the source interpolation mesh cell when it crosses the periodic boundary.
This change fixes this issue by properly validating each cell.
The change was proposed by Simon Good, I am just performing the necessary admin to get the change into atlas.
Testing
This is tricky to test, and requires a separate PR in atlas-orca to introduce a ctest to cover the issue.
An example of some of the affected interpolated points that were incorrect before this change and fixed afterwards on an eORCA025_T: