ecmwf / atlas

A library for numerical weather prediction and climate modelling
https://sites.ecmwf.int/docs/atlas
Apache License 2.0
112 stars 42 forks source link

Add HIC abstraction layer for HIP and CUDA #219

Closed wdeconinck closed 2 months ago

wdeconinck commented 2 months ago

Currently this is implemented as a stand-alone CMake package within the atlas repository.

A dummy API is available when HIP or CUDA backend is not available, to avoid #ifdef in downstream code.

Atlas has been adapted to replace all use of CUDA API with the new hic API. Even though hic is tested with HIP backend, the use of Atlas with hic has not been tested with the HIP backend. A future PR may address small fixes needed.

github-actions[bot] commented 2 months ago

Private downstream CI failed. Workflow name: private-downstream-ci-hpc View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10489952082.

github-actions[bot] commented 2 months ago

Private downstream CI succeeded. Workflow name: private-downstream-ci View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10493908782.

github-actions[bot] commented 2 months ago

Private downstream CI failed. Workflow name: private-downstream-ci-hpc View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10494127731.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 61.36364% with 17 lines in your changes missing coverage. Please review.

Project coverage is 79.95%. Comparing base (74baa23) to head (afd3b5f). Report is 7 commits behind head on develop.

Files Patch % Lines
hic/src/hic/hic_dummy/hic_dummy_runtime.h 30.00% 7 Missing :warning:
src/atlas/util/Allocate.cc 50.00% 4 Missing :warning:
hic/tests/test_hic_dummy.cc 81.25% 3 Missing :warning:
src/atlas/util/Allocate.h 50.00% 2 Missing :warning:
hic/src/hic/hic_runtime.h 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #219 +/- ## =========================================== + Coverage 79.40% 79.95% +0.55% =========================================== Files 794 792 -2 Lines 54315 62309 +7994 =========================================== + Hits 43131 49822 +6691 - Misses 11184 12487 +1303 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

Private downstream CI succeeded. Workflow name: private-downstream-ci View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10505432438.

github-actions[bot] commented 2 months ago

Private downstream CI succeeded. Workflow name: private-downstream-ci View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10505432438.

github-actions[bot] commented 2 months ago

Private downstream CI failed. Workflow name: private-downstream-ci-hpc View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10505615284.

github-actions[bot] commented 2 months ago

Private downstream CI failed. Workflow name: private-downstream-ci-hpc View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10511466778.