search

ecmwf / cdsapi

Python API to access the Copernicus Climate Data Store (CDS)
Apache License 2.0
233 stars 56 forks source link

Update to failing unit test #107

Closed EddyCMWF closed 2 months ago

EddyCMWF commented 2 months ago

The test is failing without any changes to the cdsapi source code. Presumably due to hardware changes in the CDS resulting in minor changes to metadata. This PR ensures that the result is close in size to the expected result.

I have to say, I do not know how consistent we expect this file size to be, it seems to have been stable from 2018-2024, but recent changes to the way the CDS calls MARS are probably more significant than previous changes (i.e. through a proxy server layer).

Please see report from unmodified copy of the master branch that fails the unit test: https://github.com/ecmwf/cdsapi/actions/runs/10214307701

EddyCMWF commented 2 months ago

Following discussions with colleagues, the file size has changed due to removed padding, which is a good thing. We should not expect this file size to change regularly, and when it does we should understand why. Therefore, we fix by updating the expected filesize result, not by allowing a range of expected file size