Closed Metamess closed 1 year ago
Patch coverage: 25.00%
and project coverage change: -41.73%
:warning:
Comparison is base (
177ac62
) 95.65% compared to head (d4e003c
) 53.93%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is a really nice PR, @Metamess, I'm just trying to sort out the CI before merging.
Thank you very much for this PR - you also mentioned that the test environment needed to be updated and you were right, it did just in order for this to work! That was because it required a newer ecCodes, which in turn had some new requirements, and was not supported by Python 3.7.
Thanks a lot for all the additional work Iain! Glad I could be of help 😁
Closes #348
Fixes a bug where providing
"grib_errors"
as key in backend_kwargs is required by some function (open_variable_datasets()
) but causes a TypeError due to not being a recognized parameter in others (CfGribBackend.open_dataset()
).Also fixes a test (
test_40_xarray_store.py::test_open_dataset_corrupted()
) to specifically expect the type of Error associated with the expected issue, which was masking the TypeError.Additionally, also adds the following line to
test_40_xarray_store.py::test_open_dataset()
:xarray_store.open_dataset(TEST_DATA, backend_kwargs={"errors": "raise"})
This tests that callingopen_dataset()
with a known-good GRIB file and"errors": "raise"
does not, in fact, raise an Error.