search

ecmwf / climetlab

Python package for easy access to weather and climate data
Apache License 2.0
371 stars 58 forks source link

fix the ipython type check codes #54

Closed longtsing closed 1 year ago

longtsing commented 1 year ago

I came from the MOOC in "Machine Learning in Weather & Climate" . Because the code in tiger 2 'Introduction to data handling' don't work as we think. The figure don't show in the jupyter lab, So I check the code, and find the bug in the 'climetlab.core.ipython.py '. Bug and Fix list: 1: The ipython_active do not get the handle of IPython ; 2: The code of Jupyter check is write in error ,Bucause the ipython_dir is not match the specified one.

FussyDuck commented 1 year ago

CLA assistant check
All committers have signed the CLA.

floriankrb commented 1 year ago

Thank you for finding and fixing the issue.

What about moving your additional if last in the list though. Just before return ("unknown", None). To make sure it does not break the previous ones which are more specific?

longtsing commented 1 year ago

thanks ，I will take some hours to recheck it

Thank you for finding and fixing the issue.

What about moving your additional if last in the list though. Just before return ("unknown", None). To make sure it does not break the previous ones which are more specific?

longtsing commented 1 year ago

Hello , I recheck the code and tested it in many environments.It is still working well done and is compatible with the

longtsing commented 1 year ago

close this pull request ,I will start a new one.