Open EddyCMWF opened 1 year ago
Hi @EddyCMWF , I saw your work in branch 6-transform-inputs-to-sub-packages but I am not sure this should be done in theearthkit
repo itself. In my opinion earthkit
should not contain any Python code apart from simply importing the components. Besides, components should not depend on the existence of earthkit
since we should be able to install them independently. Is it not possible to achieve what you want in one of the components that the others would use?
Maybe we could consider making a earthkit-utils ?
Oh, I just created this issue in earthkit-data: https://github.com/ecmwf/earthkit-data/issues/134 .
I think it may be good to put it in there (for now at least) as it is all based on using earthkit-data to do the conversions.
Is your feature request related to a problem? Please describe.
I'm always frustrated that I have to change the format of my data when calling a method from a sub-package.
Describe the solution you'd like
I'd like the input-objects to be automatically transformed to the correct type by earthkit, usinng the functionality that is available in earthkit-data.
Describe alternatives you've considered
No response
Additional context
Implementation will require knowledge of the data formats required by the sub-package methods. This can be inspected using:
data = np.ndarray
anddataarray = xr.DataArray
For efficient code implementation, it is probably best to use function wrappers instead of decorators. Decorators would require code additions for all functions in the sub-package, whereas a wrapped can be applied programatically. Negative aspect is it may be slower at importing.
Organisation
ECMWF