search

ecmwf / ecbuild

A CMake-based build system, consisting of a collection of CMake macros and functions that ease the managing of software build systems
https://ecbuild.readthedocs.io
Apache License 2.0
26 stars 25 forks source link

Added an insecure curl option to ecbuild_get_test_data.cmake. #43

Closed StegmannJCSDA closed 2 years ago

StegmannJCSDA commented 2 years ago

Description:

The intent of this PR is to add an 'unsafe_curl' option to function( ecbuild_get_test_data ) and all related macros. The optional flag will allow to call curl with the --insecure option to allow insecure SSL connections. The motivation for this is that some systems do not have properly configured SSL certificates to download testing data for production code.

Issues:

Acceptance criteria:

Impact:

Since the additional argument is optional, the impact should be limited to instances where insecure SSL download is wanted.

FussyDuck commented 2 years ago

CLA assistant check
All committers have signed the CLA.

StegmannJCSDA commented 2 years ago

@oiffrig no problem, thank you for having a look at the PR! Yes, I can address the comments over the next two weeks, if that's sufficient.

StegmannJCSDA commented 2 years ago

No problem. What about the test failure for ubuntu-20.04? Is that an issue? Looks like I can't check the logs at the moment.

oiffrig commented 2 years ago

We were seeing the same issue in other branches, it is not related to the PR. One of our regression tests is failing with recent versions of CMake (3.24), I will look into that.

StegmannJCSDA commented 2 years ago

Thank you.