search

ecmwf / eccodes-python

Python interface to the ecCodes GRIB/BUFR decoder/encoder
Apache License 2.0
115 stars 33 forks source link

call the builder.py script from the setup script #21

Closed jdkloe closed 4 years ago

jdkloe commented 4 years ago

This will automatically build the fast cffi based bindings. An additional advantage is that the python module gets installed below /usr/lib64/python3.x/site-packages/ now and no longer below /usr/lib/python3.x/site-packages/ When manually calling the builder.py script after having done a "setup.py build", and then adding it to the build directory, and calling "setup.py install", the module ends up below /usr/lib. This is especially important when packaging the module for a linux distribution (as I am trying to do now for Fedora), since there are strict guidelines where binary python packages need to be installed.

In case you do not wish to have a call to this builder.py script in a default install, please consider adding it as an option to the setup.py script, so it can be enabled if needed.

jdkloe commented 4 years ago

Note that the travis build fails because eccodes is not installed in that environment. My local install in which I do have eccodes installed runs just fine.

FussyDuck commented 4 years ago

CLA assistant check
All committers have signed the CLA.

shahramn commented 4 years ago

This PR breaks the Travis CI build. So cannot be merged