search

ecmwf / eccodes-python

Python interface to the ecCodes GRIB/BUFR decoder/encoder
Apache License 2.0
112 stars 32 forks source link

contribution guide refers to removed files #90

Open ejd opened 2 months ago

ejd commented 2 months ago

What maintenance does this project need?

The Get Started! section of CONTRIBUTING.rst refers to ci/requirements-tests.txt but the entire contents of the ci directory was removed back in 2021 by a6cff6a. Was the removal a mistake? Or is the contribution guide out of sync with the project's current practices?

Organisation

Self

shahramn commented 2 months ago

Thanks for spotting this. I will restore those 2 files

ejd commented 2 months ago

@shahramn Hi, thank you for addressing this. I'm sorry I didn't mention this in the original issue, but I think the real fix is to revert the entirety of a6cff6a; to restore all of the files removed by that commit.

The ci/requirements-*.txt files are built from the ci/requirements-*.in files by pip-compile via make update-req. Without the *.in files, you can't generate new *.txt files with up-to-date versions of the dependencies.

shahramn commented 2 months ago

Apologies. I will restore the files. In the future we will switch to using toml