search

ecmwf / ecflow

ECMWF's workflow manager
Apache License 2.0
39 stars 15 forks source link

Correct default status log optimization ECFLOW-1914 #47

Closed marcosbento closed 10 months ago

marcosbento commented 10 months ago

These changes correct the optimisation/inhibition of unnecessarily logging the node state change, applicable to the descendants of a node with default status COMPLETE.

Without these changes, the controlling flag was update+used and, because it was passed as reference, later incorrectly applied to siblings nodes.

To avoid similar issues in the future, all Requeue_args data members not currently updated in the scope of handling requeue are made constant.

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (24cd1c3) 80.17% compared to head (448d343) 83.57%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #47 +/- ## =========================================== + Coverage 80.17% 83.57% +3.40% =========================================== Files 577 541 -36 Lines 57977 52585 -5392 =========================================== - Hits 46481 43947 -2534 + Misses 11496 8638 -2858 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.